Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support === on empty Aggregates #3747

Merged
merged 1 commit into from
Jan 19, 2024
Merged

Support === on empty Aggregates #3747

merged 1 commit into from
Jan 19, 2024

Conversation

jackkoenig
Copy link
Contributor

Contributor Checklist

  • Did you add Scaladoc to every public function/method?
  • Did you add at least one test demonstrating the PR?
  • Did you delete any extraneous printlns/debugging code?
  • Did you specify the type of improvement?
  • Did you add appropriate documentation in docs/src?
  • Did you request a desired merge strategy?
  • Did you add text to be included in the Release Notes for this change?

Type of Improvement

  • Bugfix

Desired Merge Strategy

  • Squash

Release Notes

Reviewer Checklist (only modified by reviewer)

  • Did you add the appropriate labels? (Select the most appropriate one based on the "Type of Improvement")
  • Did you mark the proper milestone (Bug fix: 3.5.x, 3.6.x, or 5.x depending on impact, API modification or big change: 6.0)?
  • Did you review?
  • Did you check whether all relevant Contributor checkboxes have been checked?
  • Did you do one of the following when ready to merge:
    • Squash: You/ the contributor Enable auto-merge (squash), clean up the commit message, and label with Please Merge.
    • Merge: Ensure that contributor has cleaned up their commit history, then merge with Create a merge commit.

@jackkoenig jackkoenig added the Bugfix Fixes a bug, will be included in release notes label Jan 19, 2024
@jackkoenig jackkoenig added this to the 3.5.x milestone Jan 19, 2024
@jackkoenig jackkoenig merged commit da6ae7d into main Jan 19, 2024
17 checks passed
@jackkoenig jackkoenig deleted the equals-empty-aggregate branch January 19, 2024 23:07
@mergify mergify bot added the Backported This PR has been backported label Jan 19, 2024
mergify bot pushed a commit that referenced this pull request Jan 19, 2024
@jackkoenig @mergify
Support === on empty Aggregate (#3747)
8092519 
(cherry picked from commit da6ae7d)
@mergify mergify bot mentioned this pull request Jan 19, 2024
Merged
mergify bot pushed a commit that referenced this pull request Jan 19, 2024
@jackkoenig @mergify
Support === on empty Aggregate (#3747)
a5f11da 
(cherry picked from commit da6ae7d)
@mergify mergify bot mentioned this pull request Jan 19, 2024
Merged
14 tasks
mergify bot pushed a commit that referenced this pull request Jan 19, 2024
@jackkoenig @mergify
Support === on empty Aggregate (#3747)
f03e65b 
(cherry picked from commit da6ae7d)
@mergify mergify bot mentioned this pull request Jan 19, 2024
Merged
14 tasks
mergify bot added a commit that referenced this pull request Jan 20, 2024
@mergify @jackkoenig
Support === on empty Aggregates (backport #3747) (#3750)
abddf8f 
* Support === on empty Aggregate (#3747)

(cherry picked from commit da6ae7d)

* Fix for Scala 2.12

---------

Co-authored-by: Jack Koenig <koenig@sifive.com>
mergify bot added a commit that referenced this pull request Jan 20, 2024
@mergify @jackkoenig
Support === on empty Aggregates (backport #3747) (#3748)
10bfa0b 
* Support === on empty Aggregate (#3747)

(cherry picked from commit da6ae7d)

* Fix for Scala 2.12

---------

Co-authored-by: Jack Koenig <koenig@sifive.com>
mergify bot added a commit that referenced this pull request Jan 20, 2024
@mergify @jackkoenig
Support === on empty Aggregates (backport #3747) (#3749)
1dcac6a 
* Support === on empty Aggregate (#3747)

(cherry picked from commit da6ae7d)

* Fix for Scala 2.12

---------

Co-authored-by: Jack Koenig <koenig@sifive.com>
SpriteOvO pushed a commit to SpriteOvO/chisel that referenced this pull request Jan 20, 2024
@jackkoenig @SpriteOvO
Support === on empty Aggregate (chipsalliance#3747)
d9e2c2a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mwachs5 mwachs5 mwachs5 approved these changes

Assignees
No one assigned
Labels
Backported This PR has been backported Bugfix Fixes a bug, will be included in release notes
Projects
None yet
Milestone
3.5.x
Development

Successfully merging this pull request may close these issues.
2 participants
@jackkoenig @mwachs5